Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonrpc: correctly serialize bcsName field #20656

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Dec 17, 2024

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 4:40pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 4:40pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 4:40pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 4:40pm

Correctly serialize bcsName field which was unintentially changed to
`bcs_name` in 8a992f0 (jsonrpc: introduce bcsEncoding tag to ease
migration to base64, 2024-12-12)
@bmwill bmwill temporarily deployed to sui-typescript-aws-kms-test-env December 17, 2024 16:39 — with GitHub Actions Inactive
@bmwill bmwill merged commit 29f17da into MystenLabs:main Dec 17, 2024
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants